rust-x86asm icon indicating copy to clipboard operation
rust-x86asm copied to clipboard

Assembling doesn't work.

Open purpleposeidon opened this issue 6 years ago • 1 comments

Eg,

use std::io::*;
use x86asm::*;

let buffer = Cursor::new(Vec::new());
let mut writer = InstructionWriter::new(buffer, Mode::Long);
writer.write2(Mnemonic::MOV, Operand::Direct(Reg::RBX), Operand::Direct(Reg::RAX))?;

causes an unimplemented panic.

purpleposeidon avatar Sep 11 '18 06:09 purpleposeidon

Changing the unimplemented!() to false does seem to get it working:

--- a/src/instruction_def.rs
+++ b/src/instruction_def.rs
@@ -367,7 +367,8 @@ impl OperandDefinition {
                 size_helper(s.unwrap_or(def_size), op),
             OperandType::Imm => op.map(|o| o.is_literal() || o.is_offset() || o.is_far())
                 .unwrap_or(false) && size_helper(def_size, op),
-            OperandType::Offset => unimplemented!(),
+            OperandType::Offset => false,

purpleposeidon avatar Sep 11 '18 23:09 purpleposeidon