Gregory Comer
Gregory Comer
Note that the moshi and zephyr size test failures are pre-existing.
> You can use RemoveCloneOpsTransform (https://github.com/pytorch/executorch/blob/main/backends/transforms/remove_clone_ops.py) to remove extra clone and dim order clone Thanks. Do you have any objection to adding this to the to_edge flow?
> yeah i belive making it a part of to_edge flow might not be a good idea or not enough, since some "unused" clone-like op will be used after to_backend;...
I see there was some discussion around this in https://github.com/pytorch/executorch/pull/12974. Is that what you're referring to? From my understanding, the risk is specifically around removing clones which modify dim order....
Solved for XNNPACK, at least, so main issue is done. Still hoping to land the optimization for core.
Yeah, I need to revert the other PR with a more targeted fix for the UNISOCs. It may be a few days, but I'll see if I can get the...