robust-services-core icon indicating copy to clipboard operation
robust-services-core copied to clipboard

Enhance >check

Open GregUtas opened this issue 8 years ago • 0 comments

Extend the Warning enum to support any of the following:

  • [ ] use of typedef (for conversion to using type alias)
  • [ ] data member has set function but class writes directly to the member
  • [ ] packing an enum into a field that cannot hold +/- the largest absolute value of an enumerator (need to resolve ClassData.width_ to a constant)
  • [ ] assigning the result of new to a stack or member pointer instead of a smart pointer
  • [ ] redefining an inherited default argument
  • [ ] #include only required because of inlines in header (would need to modify GetUsages to track symbols that only appeared in inlines)
  • [ ] function returns a value that is never used
  • [ ] byte-sized non-char field that is displayed as a character instead of numerically (might be detected by checking for invocations of ostream::operator<< in Function.WasCalled)
  • [ ] member omitted by Display function
  • [ ] default argument specified by definition rather than declaration (default needs to be seen by the compiler at the point of usage, so the definition would probably have to be in a header to have any effect)

And the following, which are only for formatting:

  • [ ] using statement not sorted in alphabetical order
  • [ ] single rule (//---...) not used between function definitions in same class
  • [ ] double rule (//===...) not used between function definitions in different classes

GregUtas avatar Nov 11 '17 23:11 GregUtas