GregTech icon indicating copy to clipboard operation
GregTech copied to clipboard

[BUG] Redstone behavior of 16x cables altered

Open ebmusicman84 opened this issue 4 years ago • 2 comments

H4FpzJ1 Describe the bug 16x cables no longer pass a strong redstone signal through them. This behavior was last observed (by me) working as expected in GTCE 1.8.4.419.

Versions Forge: 14.23.5.2855 GTCE: 1.15.0.721 Modpack: OmniFactory Dev Branch 3326ab7

Setup New world in both SP and MP

Steps To Reproduce Apply a strong redstone signal to a 16x cable with a redstone receiver (such as a redstone lamp) on the other side.

Expected behavior The signal should be passed through the block and power the lamp. It was speculated that this may be a quirk of 16x cables no longer technically being a full block and so may be intended. However the cable does occupy the same space as a full block and while rubber is non-conductive redstone is not an electrical signal and has been show to pass through other non or low conductive materials such as obsidian, wood and stone.

ebmusicman84 avatar Jun 30 '21 23:06 ebmusicman84

I believe this was changed in #1331 because the original implementation was doing it wrong due to a vanilla minecraft "bug". https://github.com/GregTechCE/GregTech/blob/52b948d525a6c1d2e155374fe9e47033c086e4e3/src/main/java/gregtech/api/pipenet/block/BlockPipe.java#L141-L146

https://minecraft.fandom.com/wiki/Redstone_mechanics#Power According to the minecraft rules, cables are not opaque and they are themselves redstone emitters (not mentioned on that wiki page), so they can only power other blocks directly and should not pass redstone signals.

warjort avatar Jul 01 '21 09:07 warjort

Incidently, I believe the above comment is wrong to blame vanilla code. The actual name "shouldCheckWeakPower" comes from mod developers making up deobfuscated names for minecraft methods.

warjort avatar Jul 01 '21 09:07 warjort