GregTech icon indicating copy to clipboard operation
GregTech copied to clipboard

[Suggestion] Move away from enums

Open idcppl opened this issue 4 years ago • 1 comments

Is your feature request related to a problem? Please describe. A lot of the material system is attached to enums that dev's are forced to use EnumHelper for. In example,

  • https://github.com/GregTechCE/GregTech/blob/master/src/main/java/gregtech/api/unification/material/MaterialIconSet.java
  • https://github.com/GregTechCE/GregTech/blob/master/src/main/java/gregtech/api/unification/material/MaterialIconType.java
  • https://github.com/GregTechCE/GregTech/blob/master/src/main/java/gregtech/api/unification/ore/OrePrefix.java
  • https://github.com/GregTechCE/GregTech/blob/master/src/main/java/gregtech/api/unification/Element.java

Describe the solution you'd like To move these over to registration maps.

idcppl avatar Jun 06 '21 17:06 idcppl

If you are going to do this, then you need to make sure that things that depend on the ordinal still work as before.

e.g. the order that OrePrefix handlers are run

https://github.com/GregTechCE/GregTech/blob/dde025306a81abf2d7ad10561fcd3553805ca17e/src/main/java/gregtech/api/unification/ore/OrePrefix.java#L415

warjort avatar Jun 06 '21 17:06 warjort