GregTech icon indicating copy to clipboard operation
GregTech copied to clipboard

[BUG] Silicone Rubber registration is misspelled

Open million09 opened this issue 4 years ago • 3 comments

Describe the bug Silicone Rubber registration name is silicon_rubber, which should be silicone_rubber. https://github.com/GregTechCE/GregTech/blob/c76e2e3c84479c58e9d5bbbfdaef12da3ca3f2ce/src/main/java/gregtech/api/unification/material/Materials.java#L296 This results in incorrect oredictionary entries, like ringSiliconRubber.

Versions GTCE: 1.15.0

Screenshots 2021-05-30_13 20 56

million09 avatar May 30 '21 04:05 million09

Isn't this one of those issues that gets denied because it would break existing setups?

Primitive-Human avatar May 30 '21 23:05 Primitive-Human

Isn't this one of those issues that gets denied because it would break existing setups?

Probably yes. Though it could be changed in a major release. GTCE 2.x whenever that is?

Isn't it trivial for you to fix this yourself if you need the correct spelling for some reason? Just add an extra dictionary entry with the correct spelling to the items using crafttweaker.

warjort avatar May 31 '21 19:05 warjort

While you are right that this is an issue, like @warjort said, I don't think its something worth fixing right now due to the compatibility break. I will leave this open, but with the label "wontfix" for now.

serenibyss avatar Jun 05 '21 01:06 serenibyss