GregTech icon indicating copy to clipboard operation
GregTech copied to clipboard

[Suggestion] ToolProgression and Crafttweaker modification of harvest levels

Open AvilionAMillion opened this issue 4 years ago • 3 comments

Is your feature request related to a problem? Please describe. As it stands, the gregtech ores do not have changeable harvest levels, this is in contrast to most other ores in other mods, and, in my personal case, completely breaks progression possibilites for modpack makers. I may be mistaken and am overlooking a way to change GT ore harvest levels, and in that case my apologies, however currently it would be incredibly helpful to have them be able to be changed

Describe the solution you'd like I don't know much about Java, but hopefully the solution would be as simple as asking for the harvest values before placing its own in. The outcome should be the same regardless, a way of modifying the harvest levels of GT blocks.

AvilionAMillion avatar Apr 09 '21 01:04 AvilionAMillion

In GTCE the harvest level is defined on the material. For some reason this property is read only:

    /**
     * Tool level needed to harvest block of this material
     */
    @ZenProperty
    public final int harvestLevel;

The "final" indicates it can't be changed via CraftTweaker.

I guess there is some reason why changing the harvest level of a material dynamically is a bad idea, but I don't know what that is?

One alternative is to just generate your own materials for progression. You can set the harvest level of any materials you create: https://docs.blamejared.com/1.12/en/Mods/GregTechCE/Material/

But obviously that would mean doing some work to change the recipes and ore generation to use your materials. I know OmniFactory and FTB Interactions does this to some extent.

warjort avatar Apr 09 '21 12:04 warjort

I did know that adding new materials and changing their harvest levels was an option, however, considering the large amount of changes I was going to make to the whole tool progression system it would effectively require a complete restructuring of every ingot in the game, so I wasn't planning on doing that

If there is any good reason as to why the harvestLevel is final then I'd like to know, if not, it seems weird that it's there

AvilionAMillion avatar Apr 09 '21 12:04 AvilionAMillion

I believe this answers your question:

https://github.com/GregTechCE/GregTech/pull/1568#issuecomment-817241916

warjort avatar Apr 11 '21 08:04 warjort