GregTech icon indicating copy to clipboard operation
GregTech copied to clipboard

[Suggestion] Logging for when an ore vein will fail all generation attempts

Open ALongStringOfNumbers opened this issue 4 years ago • 1 comments

Is your feature request related to a problem? Please describe. Currently, it is hard to tell when an ore vein fails all of its generation attempts due to incorrectly separated minimum and maximum heights, or some other issues. The only way to check is to have a mod like world edit and use it to search in a large area for the blocks that will spawn in the vein.

Describe the solution you'd like Log a warning when the vein will fail all generation attempts due to incorrectly defined parameters

Additional context This will be sort of hard, because the generation attempts depend on the masterEntry.getMaxBottomHeight(), which will change, however general checks could be done for the maximum and minimum heights of the vein, and the radius of the vein is defined as an elliptical generator.

ALongStringOfNumbers avatar Feb 02 '21 18:02 ALongStringOfNumbers

This seems reasonable we can add logging to vein generation. And log on warning situations which could potentially lead to problems with vein generation.

LAGIdiot avatar Feb 06 '21 15:02 LAGIdiot