GregTechCE
[Suggestion] Regarding potion liquids
Is your feature request related to a problem? Please describe. I have seen multiple mods that add liquids for (each) potion and include a method of mass-producing potions and bottling them. However, some of these (mods) overlap and several of these do not allow you to properly fill a bottle with a potion liquid stored inside a tank. I have recently had to choose between Charset crafting and Inspirations, because Charset crafting allowed me to empty potions into tanks and bottle them straight into empty bottles again, a feature that Inspirations' potion liquids and GTCE liquid potions breaks and/or lacks.
Describe the solution you'd like I have two different solutions that I'd like:
-
Allow empty bottles to be filled with potions from any tank and incorporate Splash and Lingering variants for each potion as well. Right now any splash or lingering potion variants get reverted to a basic potion variant when stored in a tank.
-
Include a toggle that disables GTCE's liquid potions (and their registering). This may be an easier solution than the first, as I have witnessed that empty bottles do not properly get filled inside a bottling station. This way I can use another mod to fill empty bottles with potions from tanks.
Additional context Despite the conversations we've had in discord where we talked about howmany mB a bottle should hold, I see that all bottles are set hardcoded to 100 mB with no config option for it. Now, some mods do allow me to adjust their bottle capacity settings as well so it matches this number. However, I'd like to have a config option for this as well so I can optionally change this to 250 mB. If possible, make this a separate config option and not as part with the toggle mentioned in suggestion # 2. Otherwise consider scrapping the fluid bottle capability code for now so it won't override the implementation of another mod.
After looking a bit further, I can work around this problem by configuring Sips to treat GTCE's potion fluids as normal potions. Even though that limits me to just using regular potions and not splash or lingering potions, it's a workaround that I'll take for now. (didn't use splash/lingering potions that much anyway).
Thank you for this suggestion. We are aware that there are some problems in regards of potion making/using in GTCE. And probably this whole area would require revision. But that is quite big topic with which we would need help. And for that I am marking this as open for discussion.
GTCE was not designed to be modular with possibility to turn off whole areas. So I am not sure if we can quickly do it or we will just broke other things.
I couldn't find that disabling potion fluids would impact other parts of the mod much, as it is mostly registering a fluid for each potion and registering them to the brewery after a quick glance at these files:
https://github.com/GregTechCE/GregTech/blob/master/src/main/java/gregtech/common/CommonProxy.java https://github.com/GregTechCE/GregTech/tree/master/src/main/java/gregtech/common/items/potions
So it seems quite contained with my near non-existant knowledge of java. However, it is not of high priority as I can work around this by adding a bottling recipe for each separate potion (which for some reason does not work, even in 1.10.9.612) or by using the fluid canisters from Sips so I can directly grab fluids stored within tanks and drink them without having to route the fluids to a bottler first.
Although I am still wondering why the the amount per fluid bottle has been hardcoded at 100 mB. https://github.com/GregTechCE/GregTech/blob/4dd77f6d1f9d8a848a1836f3c7a2fb812880a748/src/main/java/gregtech/common/items/potions/PotionFluids.java#L27
Wasn't there a discussion in discord about putting that at 250 mB? If so, my suggestion is to atleast change that to 250 mB.