GregTech icon indicating copy to clipboard operation
GregTech copied to clipboard

[Suggestion] Run tests on PRs and release

Open LAGIdiot opened this issue 4 years ago • 2 comments

Is your feature request related to a problem? Please describe. Use tests as one of factors for releasing and PRs acceptance.

Describe the solution you'd like Tests should provide quick feedback on PRs if code is at least buildable and if tests does not fail. Failing tests should be able to prevent automatic (not manual) release of GTCE.

LAGIdiot avatar Jan 06 '21 23:01 LAGIdiot

maybe a test that check code quality ? it could help improve code quality of PR made by beginners (like me)

galyfray avatar Mar 04 '21 22:03 galyfray

maybe a test that check code quality ? it could help improve code quality of PR made by beginners (like me)

I think it could be include as gate check. But it should not be that problematic now, when we have .editorconfig which should enforce it.

LAGIdiot avatar Mar 07 '21 10:03 LAGIdiot