GregTech icon indicating copy to clipboard operation
GregTech copied to clipboard

[Suggestion] APIfy JEIHelpers

Open huneau opened this issue 5 years ago • 4 comments

Is your feature request related to a problem? Please describe. As a mod Dev I need to print my own values https://github.com/GregTechCE/GregTech/blob/master/src/main/java/gregtech/integration/jei/utils/JEIHelpers.java#L10

Describe the solution you'd like An idea could be to make the 2 values public that way I can modify it. Just to be clear I need JEIHelpers to be more versatile I don't talk to GTValues I let you suggest to me a solution and then I will implement it

huneau avatar Nov 05 '20 18:11 huneau

I understand your request and I would like to comply. But honestly I am not sure how to handle this. GTCE integration with JEI was never meant to be part of public API. And we never intended to have more tiers. I mean I am OK with your addon adding them but as you can see we are not ready to handle them.

Only implementation that comes to my mind is through two providers one for Voltage and second for VoltageNames which would supply GTCE values as default and you could wire them to yours. But I am not sure if it is feasible or even clear. What you think about it?

LAGIdiot avatar Nov 12 '20 09:11 LAGIdiot

Could be an idea, we talk about render voltage name for QoL and thats it, the provider solution seems fine to me.

huneau avatar Nov 13 '20 16:11 huneau

Okay then let's go with it, I will leave implementation to you.

LAGIdiot avatar Nov 14 '20 12:11 LAGIdiot

I finally find how to manage this issue. I delete the JEI GTCE category and replace it with a Gregicality category and seems working as expected.

huneau avatar Dec 23 '20 13:12 huneau