GregTechCE
[Suggestion] Streamline The Different Material Based Frames And Possibly Ores.
JEI Clutter The generated frames from different materials are nice, but they take up many JEI entries that are basically nothing but redundancy.
Potential Solution Considering how all the colored frames seem to be the exact same, just made with different materials, the number of entries could be reduced to 1/16 the number of displayed items if the format of these items could be changed to "(Material name) Frame" and include a tool tip that informs the player that it can be dyed.
Additional context I'm not sure if this can be done with NBT data, but I know other mods have the ability to do something very similar, and with my extremely limited knowledge of Minecraft modding, I.E. just adding in basic blocks, I'm not sure how this is done. If not, at the very least, the clutter could be reduced by auto hiding anything other than the base form of the frame's material and adding a tool tip.
I know other mods have altered blocks when placed in the world, without having them accessed through mods like JEI and I'm also wondering if this could be done to the auto wrapping system with ores somehow. I understand it is useful to see how an ore can be processed, but I'm wondering if there is an alternative to the current system, because in large modpacks or even with just RailCraft installed, the number of generated ores showing up in JEI becomes insane due to poor and pure variants, and it becomes exponential at some point. (8,006 ore entries just from GregTech on the custom pack being described, or 8.3% of all shown items, even with JEI hide mode setup for various things, so you can see how it can become cumbersome. This is even without some dimension mods being added that makes it even worse.)
Actually In terms of streamlining JEI and how it integrates ores... If all the ore variants for the same material sub-class like granite ("Material" Granite Ore") yield the same byproducts (Ore Product, Byproduct, Byproduct), then perhaps those could be reduced to a material group somehow, with a way to allow players to understand what those byproducts are from those respective material groups, without having to list all those variants as separate blocks for recipes. In-Game documentation may be helpful for something like this, but I don't think it's a silver bullet to the solution.
Move some recipes with same output to oredict? That would definitely simplify some machines with less-than-stellar efficiency.
Thank you for creating this suggestion.
1 ) In regards of Frame streamlining it can be arranged. They are nearly same item (just with different metadata) so showing just default of them should not be problem. This will for GTCE alone reduce use of JEI by 191 items (from 204 to 13) which is 2,6%. This part is accepted.
Implementation notes: Add config option to hide colored variants of Frames from JEI. Add tooltip to frames that colored variant can be crafted. Don't register colored variant of Frames in JEI.
2 ) For ore streamlining I have to honest there is nothing we can do with it. Our ore generating system is based on old model where every ore itemblock it is it's own thing. It is not just "color" easy thing as in Frame case. There is no way how to categorize then and even oreDictionary is not usable in this case as our 14 ores types is across 9 entries. Any touch which could solve this situation will create save breaking and addon breaking incompatibility. This part is rejected.
-
Thank you for this, it is very appreciated. (The percent calculation were only from the personal pack I was creating, sorry if that may have caused some degree of confusion.)
-
That's unfortunate, although I can understand your reasoning completely. Perhaps, even though it isn't likely in your scope at the moment, the way ores are implemented could be changed when porting to a much newer version of Minecraft in the future. Thanks for the info and consideration though!
I have worked on this, and gotten it in a state such that there is a config option to hide the colored frames, which if it is true hides the colored frames in JEI. However, the recipes for the colored frames still show up when checking on the usages of the frame and recipes that use frames still show all frames, instead of showing the uncolored frame only. Is this the desired implementation of the feature?
