Greg Hanson

Results 91 comments of Greg Hanson

I stepped through this with a debugger. This is the Loop that never terminates: https://github.com/KonradHoeffner/hdt/blob/main/src/triples/predicate_object_iter.rs#L30 This is a case where there should be no matches found. The loop should eventually...

There is a similar infinite loop when `high = mid = low`

done! I think I did that right since my import of the branch compiles

you are right! that was my mistake. I think I got them all now

Thanks for the comments @timplication @KonradHoeffner > So to work this feature into the library will probably constitute some significant refactoring. That was my impression too after reviewing the library...

@KonradHoeffner Not sure if this it's worthy of a separate issue but I had another idea/question that also revolves around performance. Is there a potential benefit to exporting the index...

Definitely interested, pending analysis of any memory consumption/time tradeoffs. I am worried a large portion of the initial load time of the HDT file is still going to be spent...

I made a first pass at the implementation. Just some custom Serialize/Deserialize functions for TriplesBitmap, diff here: https://github.com/GregHanson/hdt/commit/b065a66a2b71c16436777f62c1bf978c1695d459 First pass just leverages `serde` and `bincode` crates for saving/reading the cache...

No rush on the review, I just wanted to get a first pass out there so I could start collecting some preliminary performance numbers. I have some HDT files built...

> Interestingly, this circles back to the memory mapping problem from above :-) Oh no, you found me out! > It would also be interesting to see, which of the...