localize-router icon indicating copy to clipboard operation
localize-router copied to clipboard
verified publisher icon Greentube

ng9 support

Open deerua opened this issue 5 years ago • 6 comments

PR Checklist

Please check if your PR fulfills the following requirements:

  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • [ ] Bugfix
  • [ ] Feature
  • [ ] Code style update (formatting, local variables)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] Documentation content changes
  • [x] Other... Please describe:

ng9 support

What is the current behavior?

Issue Number: N/A

What is the new behavior?

now it support angular 9 and Ivy

Does this PR introduce a breaking change?

  • [x] Yes
  • [ ] No

Other information

deerua avatar Mar 11 '20 23:03 deerua

@deerua : Does this merge give the compatibility to the localize router for allowing working with ng9? I am trying to do this for quite a long time.

arangelp avatar Mar 24 '20 19:03 arangelp

@deerua : Does this merge give the compatibility to the localize router for allowing working with ng9? I am trying to do this for quite a long time

i have same problem. Did you check that is it resolved

mehmetatacan avatar Mar 24 '20 19:03 mehmetatacan

Tomorrow i will try it. This is my major blocker to ng9. i cross fingers :)

arangelp avatar Mar 24 '20 19:03 arangelp

@arangelp @mehmetatacan works fine in our big project i'll add some changes - but it for testing

deerua avatar Mar 26 '20 21:03 deerua

@arangelp @mehmetatacan works fine in our big project i'll add some changes - but it for testing

Thanks for reply, I will try as soon as possible

mehmetatacan avatar Mar 26 '20 22:03 mehmetatacan

Please!!! Check this PR we need for our project! Thanks in advance!

Ismaestro avatar Jun 23 '20 17:06 Ismaestro