localize-router icon indicating copy to clipboard operation
localize-router copied to clipboard

Angular 8 support

Open gilsdav opened this issue 5 years ago • 6 comments

I'm submitting a ... (check one with "x")

[ ] bug report => Search github for a similar issue or PR before submitting
[x] feature request => Please check if similar feature request does not exist
[ ] support request => Suggested place for help and support is [stackoverflow](https://stackoverflow.com/), search for similar question before posting

Description

Here is how I updated my fork : https://github.com/gilsdav/ngx-translate-router/compare/ca881c27954d878554976b8b3fed92dea1b98c63...master

Hope it will help

gilsdav avatar Jun 10 '19 19:06 gilsdav

@gilsdav Unfortunately this solution is not going to work with AOT enabled. You're trying to inject compiler which is not available at runtime.

Is there any way to do it differently without accessing compiler?

kamilchlebek avatar Jun 26 '19 08:06 kamilchlebek

@kamilchlebek ngx-translate-router is now compatible AOT and Universal on Angular 8 with the version 2.0.1

gilsdav avatar Jul 09 '19 19:07 gilsdav

Thank you, I'll check it out

kamilchlebek avatar Jul 10 '19 07:07 kamilchlebek

Any updates on this?

mateobelanger avatar Aug 12 '19 15:08 mateobelanger

Yes it's all good now. 2.0.1 works for AOT and JIT

kamilchlebek avatar Aug 12 '19 15:08 kamilchlebek

Hi Guys, can anyone give me an example that how should work this in node? I've mean, the configuration for the browser.module it's fairly OK, but in the server side it seems not complete at all, I've reviewed a lot of outdated repos using this localize-route and others but it doesn't seem to work on compilation. Please if anyone has a better example of how should work this in server side please share with me, so far the only thing that I've, (following all steps in the README.md from this repo) is an ERROR [Error] in (node) server side. When I'm setting up the application in debug mode works like a charm but not in the same way after compilation process. Thanks!

BruneXX avatar Sep 14 '19 14:09 BruneXX