localize-router icon indicating copy to clipboard operation
localize-router copied to clipboard

Fixed parseSegmentValue bug when route contains data object

Open cariboufute opened this issue 6 years ago • 3 comments

PR Checklist

Please check if your PR fulfills the following requirements:

  • [ ] Tests for the changes have been added (for bug fixes / features) (sorry, tried but was overwhelmed by all the fake router properties to fake)
  • [ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • [X] Bugfix
  • [ ] Feature
  • [ ] Code style update (formatting, local variables)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] Documentation content changes
  • [ ] Other... Please describe:

What is the current behavior?

Issue Number: #152

What is the new behavior?

The URL now changes with locale change even when the path is '' and there is a data key in the route object.

Does this PR introduce a breaking change?

  • [ ] Yes
  • [X] No

Other information

cariboufute avatar Jan 30 '19 20:01 cariboufute

Please merge this

timmyrosen avatar Apr 16 '19 09:04 timmyrosen

Also facing this bug. @cariboufute Did you manage to find any workaround until the PR merged? Is there an easy way to use your fork?

kadosh1000 avatar Jan 22 '20 13:01 kadosh1000

@kadosh1000 Yes, you just have to fork my copy of localize-router : https://github.com/cariboufute/localize-router

cariboufute avatar Jan 23 '20 21:01 cariboufute