treetracker-web-map-client
treetracker-web-map-client copied to clipboard
Greenstand
feat(cwn-dashboard): added a preview of the customizable navbar
Description
Fixes #1130
Type of change
- [x ] New feature (non-breaking change which adds functionality)
Screenshots
How Has This Been Tested?
- [x ] Cypress integration
Checklist:
- [ x] I have performed a self-review of my own code
- [x ] I have commented my code, particularly in hard-to-understand areas
- [x ] My changes generate no new warnings
- [ x] I have added tests that prove my fix is effective or that my feature works
Great to see you working on the Customizable Web Map! I have to think about this because soon I am going to introduce a new config prop to the Navbar component when getting the data from the server instead of localstorage. I think that will simplify the "transport" of the data. I'll keep you posted when I got the new prop in place!
@RubenSmn Yeah there are some details I noticed about the current implementation.
- Changes made on the admin navbar are applied immediately to the live version (may not be preferrable)
- Reactive updates on the navbar would require accessing the localStorage multiple times. Anyways, please do. Thanks!
@andrewsu31098 we can almost resume this feature. The new state management for the config on the web map has made some progress #1349.
Instead of introducing a new config prop we opt to go for a context. Meaning we can pass the config to the context and wrap it around the navbar which should take care of the rest!
@RubenSmn Sounds good! I'll keep my eyes on #1349 and open up a new PR when I get the go ahead.
@dadiorchen I talked to @andrewsu31098 about this over slack. Discussing that the data of the cwm can now be used via React context. This PR will be ready soon
@RubenSmn apologies for the absence. I intended to continue with this but i've picked up some new responsibilities that have taken up some my free time. Please feel free to ask me any questions or take any code instead as I can't guarantee a timeline.