ArchR icon indicating copy to clipboard operation
ArchR copied to clipboard

Suggestion in .createGroupBW

Open lldelisle opened this issue 1 year ago • 1 comments
trafficstars

Dear ArchR developers, While trying to integrate the createGroupBW in Signac I realized that I think there is a small mistake in: https://github.com/GreenleafLab/ArchR/blame/d9e741c980c7c64e5348c97a74d146cc95f8ba76/R/GroupExport.R#L340 I think it should be:

        i = c(trunc(x = (start(x = fragik) - 1) / tileSize),
              trunc(x = (end(x = fragik) - 1) / tileSize)) + 1,

Because if the end (or start) position of a fragment is 100 and your tileSize is 100, you would like to assign it to the first bin. Currently 100/100 + 1 assign it to the second bin.

lldelisle avatar Oct 03 '24 04:10 lldelisle

Hi @lldelisle! Thanks for using ArchR! Lately, it has been very challenging for me to keep up with maintenance of this package and all of my other responsibilities as a PI. I have not been responding to issue posts and I have not been pushing updates to the software. We are actively searching to hire a computational biologist to continue to develop and maintain ArchR and related tools. If you know someone who might be a good fit, please let us know! In the meantime, your issue will likely go without a reply. Most issues with ArchR right not relate to compatibility. Try reverting to R 4.1 and Bioconductor 3.15. Newer versions of Seurat and Matrix also are causing issues. Sorry for not being able to provide active support for this package at this time.

rcorces avatar Oct 03 '24 04:10 rcorces