Heiko Henning
Heiko Henning
@jonaslagoni How can we get here any progress?
> Before I do deeper review can you please explain the idea behind this function. As explained in latest community meeting where you was in vacation ;-) The main idea/problem...
> you expose it as standalone function, why not using it only in asyncapi.js during construction? like we do with anonymous Ok i remoted the `generateIdsInSpec` from `types.d.ts` now it...
... revert the post message, after retesting ... I not expected to be still referenced after dereferencing. Just no that are no ids any more but still the same js...
@derberg I changed it to use https://github.com/asyncapi/parser-js/blob/master/lib/models/asyncapi.js#L39-L42 But now the code is harder to read. Please see the test case for an example. Clean up git history will be done...
@derberg Can you please review again?
> Am I missing something The sample `zbos_mqtt-all-asyncapi` defines 2 schema: "percentage" and "key" but all the big rest is defined anonymous in the `channels` section. The approach only works...
@derberg @jonaslagoni What is the editor and editor settings you use for this project? vscode will always auto format all files for me, caused by the unequal coding styles.
@derberg @jonaslagoni I updated the PR and tried to respect all your inputs. Can you review again? There is still one open change request in githup but i have no...
@[smoya](https://github.com/smoya) Thanks for all your spell checks and improvement suggestions!