carbon-aware-sdk icon indicating copy to clipboard operation
carbon-aware-sdk copied to clipboard

Published 20 hours ago • verified publisher icon Green-Software-Foundation

Add example for 'podman play kube'

Open YaSuenag opened this issue 2 years ago • 13 comments
trafficstars

Pull Request

Summary

I'd like to propose to add example for CASDK demonstration.

This example provides both the SDK and Swagger UI with just one command. Thus demonstrator does not need to prepare each components for WebAPI. I used this in GSF Meetup Tokyo, then it works fine!

This example would use CASDK WebAPI container image tagged pre from GitHub Packages.

Changes

  • samples/casdk-demo (new)

Checklist

  • [ ] Local Tests Passing?
  • [ ] CICD and Pipeline Tests Passing?
  • [ ] Added any new Tests?
  • [x] Documentation Updates Made?
  • [ ] Are there any API Changes? If yes, please describe below.
  • [x] This is not a breaking change. If it is, please describe it below.

Are there API Changes?

No

Is this a breaking change?

No

Please follow GitHub's suggested syntax to link Pull Requests to Issues via keywords

This PR Closes #<issue_number>

YaSuenag avatar Apr 27 '23 00:04 YaSuenag

This a stale pull request. Please review, update or/and close as necessary.

github-actions[bot] avatar Aug 25 '23 06:08 github-actions[bot]

I'd like to contribute this example because this manifest would be useful to demonstrate the SDK with just single command on Linux box.

YaSuenag avatar Aug 25 '23 09:08 YaSuenag

@Willmish or @danuw would be great to get your review on this one

vaughanknight avatar Nov 07 '23 08:11 vaughanknight

I think @Willmish already has podman but otherwise happy to install next week and review.

danuw avatar Nov 07 '23 20:11 danuw

@Willmish assigned this to you for now as I know you have podman and can probably review this quickly... let me know otherwise

danuw avatar Nov 14 '23 08:11 danuw

#417 @Willmish to look at for next week

Willmish avatar Nov 21 '23 08:11 Willmish

@Willmish any news please?

danuw avatar Dec 05 '23 08:12 danuw

@YaSuenag let me know if you have a few minutes to go over this at some point. Also, ideally make the update so we have a settings template that does not get tracked.

danuw avatar Feb 21 '24 09:02 danuw

@danuw FYI @YaSuenag cannot see your comments, so is unable to review. @danuw please resubmit your comments to unblock review

Sophietn avatar Mar 05 '24 08:03 Sophietn

Thanks @danuw for your comment! I updated this PR.

  • This PR is no longer to have casdk-config.yaml - it would be auto-generated from environment variables. See updated README: https://github.com/YaSuenag/carbon-aware-sdk/tree/podman-example/samples/casdk-demo#example
  • The error what you saw might be caused by SELinux. I added demo.sh to start/stop the demonstration - it would work whether SELinux is enabled or not. Can you test ./demo.sh start to run?
    • You can stop via ./demo.sh stop. See README.md for details.

YaSuenag avatar Mar 09 '24 11:03 YaSuenag

This PR have to be aware of exposed port from Web API. So I want to tweak this PR after .NET 8 migration.

YaSuenag avatar Mar 09 '24 15:03 YaSuenag

This PR is blocked by #489 - we need to fix port number of WebAPI container after #489.

YaSuenag avatar Mar 13 '24 13:03 YaSuenag

I updated this PR to refer new (.NET 8 migrated) pre WebAPI container. Please review! @danuw @Willmish

YaSuenag avatar Apr 11 '24 23:04 YaSuenag

It works on my environment:

Fedora 40 スクリーンショット 2024-06-04 171256

Ubuntu 24.04 (WSL2) スクリーンショット 2024-06-04 171856

YaSuenag avatar Jun 04 '24 08:06 YaSuenag

I also tried. It worked as expected in my environment.

image

tiwatsuka avatar Jun 05 '24 04:06 tiwatsuka