carbon-aware-sdk icon indicating copy to clipboard operation
carbon-aware-sdk copied to clipboard

[Feature Contribution]: Geocode support in the API

Open vaughanknight opened this issue 2 years ago • 10 comments

What happened?

While cloud datacenters lean towards having named locations (not having to remember geocodes) when looking at client side carbon aware decisions, the use case for geocoordinates is very strong.

This feature would be to add geocode support to any of the API's where named locations are supported (and geocodes are not).

This is likely a large change, and will need considerable impact analysis to ensure we do it cleanly.

Code of Conduct

  • [X] I agree to follow this project's Code of Conduct

Feature Commitment

  • [X] I commit to contributing this feature as a PR and working with the GSF to merge this feature into the Carbon Aware SDK.

vaughanknight avatar Oct 27 '22 09:10 vaughanknight

Mentioned in #115

Willmish avatar Mar 01 '23 15:03 Willmish

This feature unlocks many use-cases around end user device carbon awareness. EG home computer: time-shifted file downloads, uploads; smart home devices: managing power consumption for car chargers, appliances, etc.

Design Recommendations

  • Ability to configure multiple LocationSources and have them applied in a specific order.
  • Keep location input type as single string value (even for lat,long geospacial coordinates) and let the location source resolve the string into something well-formed.
  • Caching needs to be considered here. Whether it's documenting a recommended approach for operators to put in front of the SDK or baking it into the solution. But simply using a geocoordinate as the key will have many cache misses, it would be great to have a solution that handles that a bit smarter.

bderusha avatar Mar 28 '23 18:03 bderusha

Another comment on this:

Having multiple LocationSources is a significant change that should have an approved ADR before it is implemented.

bderusha avatar Apr 26 '23 14:04 bderusha

Update from #355 : Lot of possible implications from the carbon perspective (might allow for not a good use of the CA SDK). Not on track for v1.1, looking to implement in v1.2.

Willmish avatar May 23 '23 07:05 Willmish

Update from #384: we are post v1.1 release, so this again is open for discussions and implementation considerations

Willmish avatar Aug 15 '23 07:08 Willmish

This issue has not had any activity in 120 days. Please review this issue and ensure it is still relevant. If no more activity is detected on this issue for the next 20 days, it will be closed automatically.

github-actions[bot] avatar Dec 14 '23 06:12 github-actions[bot]

@Willmish shall we owe this? I feel this is needed.

danuw avatar Jan 02 '24 01:01 danuw

This issue has not had any activity in 120 days. Please review this issue and ensure it is still relevant. If no more activity is detected on this issue for the next 20 days, it will be closed automatically.

github-actions[bot] avatar May 01 '24 06:05 github-actions[bot]

This issue has not had any activity in 120 days. Please review this issue and ensure it is still relevant. If no more activity is detected on this issue for the next 20 days, it will be closed automatically.

github-actions[bot] avatar Aug 30 '24 06:08 github-actions[bot]

This should still be on our raodmap, however low as this is a request that comes back often - wonder if next time we get a request, we also get a PR for a suggested implementation :)

danuw avatar Sep 03 '24 07:09 danuw