graylog2-server icon indicating copy to clipboard operation
graylog2-server copied to clipboard

Configurable indexset templates

Open patrickmann opened this issue 1 year ago • 3 comments

Adds support for configurable indexset templates.

Part of https://github.com/Graylog2/graylog2-server/issues/19075 /jpd Graylog2/graylog-plugin-enterprise#7055

Todos

  • [x] add check that built in templates cannot be edited/deleted
  • [x] Check: cannot delete the current default template (Anton)
  • [x] Check: warm tier repositories cannot be delteted if used in index set template (Anton)
  • [x] Fix audit events for /system/indices/index_set_defaults (Anton)
  • [x] provide different built-in templates for cloud/on-premise
  • [x] add built-in boolean fields to template DTO
  • [x] add default boolean fields to template DTO (Anton)
  • [x] Add index set template tab
  • [x] Make sure that index set template tab is not visible on cloud
  • [x] Make sure that index set template routes are not reachable on cloud
  • [x] Add index set template list with
    • [x] default label
    • [x] Name, description and built_in column
    • [x] Actions (not for built-in templates)
      • [x] Edit
      • [x] Set as default (if not default)
      • [x] Delete (if not default)
  • [x] Use new template defaults API for default values
  • [x] Remove old Index Set defaults configuration code and section in System Configuration
  • [x] Clean up index set form layout
  • [x] Make Data Tiering components reusable
  • [x] Clean up index set form layout
  • [x] make Data Tiering components reusable
  • [ ] Add WarmTier Summary to Template Detail view

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Refactoring (non-breaking change)
  • [x] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [x] My code follows the code style of this project.
  • [x] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [ ] I have read the CONTRIBUTING document.
  • [ ] I have added tests to cover my changes.

patrickmann avatar Apr 09 '24 16:04 patrickmann

@grotlue When resizing the width of the window, there is a certain size where the tabs completely disappear. Both larger and smaller is fine.

image

patrickmann avatar May 21 '24 12:05 patrickmann

Rotation strategy and Retention strategy are mandatory inputs. Update Template button should probably be grayed out if these are empty. Otherwise you get an ugly error message when submitting. image

patrickmann avatar May 21 '24 12:05 patrickmann

Rotation strategy and Retention strategy are mandatory inputs. Update Template button should probably be grayed out if these are empty. Otherwise you get an ugly error message when submitting. image

@patrickmann Good point! I just pushed a commit that should validate those selects in the frontend.

grotlue avatar May 22 '24 09:05 grotlue