graylog2-server
graylog2-server copied to clipboard
Alternate colors between rows in data table.
Description
Motivation and Context
This PR is a small enhancement to the data table, alternating colors between rows for better readability. It also includes changing the color from the header row to a blue-ish (when using default colors) which might be debatable, but I think the overall effect is an improvement.
How Has This Been Tested?
Screenshots (if appropriate):
Before:
Light:
Dark:
After:
Light:
Dark:
Types of changes
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Refactoring (non-breaking change)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
Checklist:
- [x] My code follows the code style of this project.
- [ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
- [x] I have read the CONTRIBUTING document.
- [ ] I have added tests to cover my changes.
this is radical! My one feedback is that I think the colour contrast between the alternating shades should be made more subtle. the human eye doesn't need the colors to be that different in order to pick up the rows. Example:
@tellistone: I toned down the colors a bit, please check the screen shots. I am not happy with the dark theme version yet, I think the background of the header and the alternate rows should be switched.
@dennisoelkers
re: light theme, I think maybe there is not quite enough contrast between color used for the header and that used the alternate rows
re: dark theme, I agree that the background of the header and the alternate rows should be switched, convention is for header to be darker shared than the table content
Closing in favor of #13384.