fpm-recipes icon indicating copy to clipboard operation
fpm-recipes copied to clipboard

Declare integrations_scripts_dir regardless of presence of enterprise plugins

Open drewmiranda-gl opened this issue 1 year ago • 1 comments

This is to address edge cases where server.conf may be missing this configuration: https://github.com/Graylog2/graylog-plugin-enterprise/issues/7616

Because there is no default value, it can lead to unexpected and unwanted (and undocumented) behavior. We do (wrongly) document server.conf having a default value when in actuality it doesn't, or its default value is conditional on server.conf being created from the enterprise install package.

I think an elegant solution to this is to just include this config for all installs such as graylog-server in addition to graylog-enterprise

integrations_scripts_dir = /usr/share/graylog-server/scripts

drewmiranda-gl avatar Jul 08 '24 14:07 drewmiranda-gl

For this one, just need to add that line of config to be included in server.conf by default

tellistone avatar Jul 22 '24 14:07 tellistone

@tellistone Is this a build issue, since it is filed in the FPM repo? Also confused by this comment, from the same day that the issue was filed.

patrickmann avatar Sep 19 '24 09:09 patrickmann

I believe the intention is to have recipes/graylog-server/patches/graylog-server.conf.patch

include +integrations_scripts_dir = /usr/share/graylog-server/scripts the same as recipes/graylog-enterprise/patches/graylog-server.conf.patch2 does.

Regarding the original issue, that was to suggest that graylog-server (The service/app) itself have a default value in the event that the integrations_scripts_dir property was missing from server.conf. That was rejected but the compromise is to have the package include integrations_scripts_dir for the graylog-server package.

drewmiranda-gl avatar Sep 19 '24 17:09 drewmiranda-gl

Fixed in https://github.com/Graylog2/fpm-recipes/commit/4ecde4997c37446f88fb8e3999569a72b79dd90b.

bernd avatar Sep 23 '24 10:09 bernd