collector-sidecar icon indicating copy to clipboard operation
collector-sidecar copied to clipboard

Check usage of global variables

Open bernd opened this issue 6 years ago • 0 comments

Problem description

We are using global registries in some places which are not thread-safe and we have to check if this can become a problem.

I found global registries here:

  • system/status.go: GlobalStatus = &Status{}
  • assignments/assignment.go: Store = &assignmentStore{make(map[string]string)}
  • backends/registry.go: Store = &backendStore{backends: make(map[string]*Backend)}

We should check if there are more.

bernd avatar Jun 27 '18 18:06 bernd