sc2reader icon indicating copy to clipboard operation
sc2reader copied to clipboard

New s2protocol

Open cjb opened this issue 9 years ago • 4 comments

Hi, I haven't contributed before, but I see that Spawning Tool's failing to parse new replays and there's a new s2protocol released six days ago:

https://github.com/Blizzard/s2protocol/commit/d62b17cd12790c5a96164757b7731100ee8596e2

cjb avatar Oct 31 '16 21:10 cjb

@dsjoerg looks like you already tackled this with your last 3 commits on https://github.com/ggtracker/sc2reader ?

As a general point, I guess it seems that this repo isn't really being maintained, where both ggtracker and spawningtool both maintain forks. should we centralize and have a new official sc2reader repo?

StoicLoofah avatar Oct 31 '16 21:10 StoicLoofah

@StoicLoofah fine by me, I can give you push rights to https://github.com/ggtracker/sc2reader or I can switch to using a new one if you prefer.

dsjoerg avatar Nov 01 '16 12:11 dsjoerg

I'm down to use the ggtracker branch: it's almost certainly the best maintained. I myself am too lazy to write tests 😛

@GraylinKim can you assign @dsjoerg as the owner of sc2reader on pypi so we can start pushing official releases there again?

StoicLoofah avatar Nov 01 '16 15:11 StoicLoofah

Oh yes, please do that. It was starting to get difficult to untangle everything and to know where to look for and merge. (Although it has been quite some time since the last time)

EHadoux avatar Nov 04 '16 09:11 EHadoux