gravity-pdf
gravity-pdf copied to clipboard
v5 UI enhancement for GF 2.5 (Backward Compatibility)
Description
GPDF v5 UI enhancement for the new GF 2.5 (Backward Compatibility)
Testing instructions
Screenshots
Checklist:
- [x] I've tested the code.
- [ ] My code is easy to read, follow, and understand
- [ ] My code follows the accessibility standards.
- [ ] My code has proper inline documentation / docblocks.
Additional Comments
@debbieellis7 the PR needs to be done on the v5 branch please
Codecov Report
Merging #1281 (89ccbfd) into v5 (632ecef) will decrease coverage by
45.73%. The diff coverage is11.65%.
@@ Coverage Diff @@
## v5 #1281 +/- ##
=============================================
- Coverage 63.59% 17.85% -45.74%
- Complexity 0 2939 +2939
=============================================
Files 261 264 +3
Lines 10999 11092 +93
Branches 226 226
=============================================
- Hits 6995 1981 -5014
- Misses 4004 9111 +5107
| Impacted Files | Coverage Δ | |
|---|---|---|
| api.php | 4.16% <0.00%> (-88.52%) |
:arrow_down: |
| pdf.php | 0.00% <ø> (-80.25%) |
:arrow_down: |
| src/Controller/Controller_Actions.php | 46.03% <ø> (-53.97%) |
:arrow_down: |
| src/Controller/Controller_Activation.php | 0.00% <ø> (ø) |
|
| src/Controller/Controller_Debug.php | 0.00% <ø> (-95.00%) |
:arrow_down: |
| src/Controller/Controller_Form_Settings.php | 13.20% <ø> (-62.27%) |
:arrow_down: |
| src/Controller/Controller_Install.php | 3.70% <ø> (-90.75%) |
:arrow_down: |
| src/Controller/Controller_Mergetags.php | 0.00% <ø> (-100.00%) |
:arrow_down: |
| src/Controller/Controller_PDF.php | 0.00% <ø> (-87.61%) |
:arrow_down: |
| src/Controller/Controller_Pdf_Queue.php | 0.00% <0.00%> (-85.86%) |
:arrow_down: |
| ... and 347 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 0b0b40d...89ccbfd. Read the comment docs.
@jestonihpi this branch needs testing with GF2.4, GF2.5, and GF2.6 to see how well the UI holds up (it doesn't need to be perfect, but better than the existing UI for the v5 branch.
v5 will soon be unsupported. Not going to include this.