Graviton-App icon indicating copy to clipboard operation
Graviton-App copied to clipboard

[Improvement] Language server protocol

Open tejainece opened this issue 5 years ago • 9 comments

If Graviton implements Language server client protocol, it would instantly get support for all programming languages.

tejainece avatar Jun 10 '19 19:06 tejainece

I already use Codemirror for highlighting the languages syntax, I still have to configure it to support more languages

marc2332 avatar Jun 10 '19 19:06 marc2332

Language server has nothing to do with Syntax highlighting. It is used for code completion, go to declaration, list references, refactoring, etc. Advanced programming language features.

tejainece avatar Jun 10 '19 20:06 tejainece

My bad! Do you mean LSP right?

marc2332 avatar Jun 10 '19 21:06 marc2332

Does the protocol need to be implemented into the core? Or can it be a "plugin" as well, because I would prefer that advanced features be kept as plugins rather than built-in, since Graviton is all about minimalism.

Also, just found out about this project a few days ago, seems really interesting! I'll be hoping to contribute once exams finish :)

mhmood-sf avatar Jun 11 '19 04:06 mhmood-sf

I have to see how it works so right now I cannot really tell you, but I will try to understand how does it work

Great! All type of helps are welcome 🙏

marc2332 avatar Jun 11 '19 08:06 marc2332

I agree with @Quantomistro3178, especially that in the 'about' section there's a part about not sending any kind of data to any server. This is definitely one of the core reasons one might have for using Graviton over a different editor.

Maybe not the best example but I remember a lot of people being angry with Atom for having telemetry enabled by default.

RoughTomato avatar Jun 17 '19 04:06 RoughTomato

Okay, I am on it.

https://github.com/Graviton-Code-Editor/Graviton-App/commit/03de04fa2d0686cba709cecb4a96ce59435d77f4

marc2332 avatar Jul 10 '20 17:07 marc2332

I think that you can close this issue. This has already been implemented in sooner versions

ghost avatar Jul 21 '20 21:07 ghost

Once I make the next release I'll close this

marc2332 avatar Jul 21 '20 21:07 marc2332