Grasscutter icon indicating copy to clipboard operation
Grasscutter copied to clipboard

Update gc to 3.3

Open Simplxss opened this issue 2 years ago • 4 comments

Description

Please carefully read the Contributing note and Code of conduct before making any pull requests. And, Do not make a pull request to merge into stable unless it is a hotfix. Use the development branch instead.

Issues fixed by this PR

fix most features

musicgame was delete because of lack of protos.

Type of changes

  • [x] Bug fix
  • [x] New feature
  • [x] Enhancement
  • [ ] Documentation

Checklist:

  • [x] My code follows the style guidelines of this project
  • [x] My pull request is unique and no other pull requests have been opened for these changes
  • [x] I have read the Contributing note and Code of conduct
  • [x] I am responsible for any copyright issues with my code if it occurs in the future.

Simplxss avatar Dec 11 '22 12:12 Simplxss

尘歌壶、怪物血量、商店 这个提交有修复了吗😲

Clout333 avatar Dec 11 '22 14:12 Clout333

soon

Simplxss avatar Dec 11 '22 15:12 Simplxss

As far as I know, some of these proto's are useless and some CMDIDs are wrong

ChisatoNishikigi73 avatar Dec 12 '22 07:12 ChisatoNishikigi73

As far as I know, some of these proto's are useless and some CMDIDs are wrong

useless protos will be delete later

Which CMDID is wrong? I will fix them

Simplxss avatar Dec 12 '22 07:12 Simplxss

尘歌壶、怪物血量、商店 这个提交有修复了吗😲

all fixed

Simplxss avatar Dec 13 '22 11:12 Simplxss

5a9c8c1的标题好像有一个拼写错误XD updata -> update

PA733 avatar Dec 21 '22 23:12 PA733

So far in my testing, this looks good to me. I noticed one bug - that was probably around before already - with costume switching. You can't switch costumes when the character is not in the active party. This is easily fixed by extending the check in line 61 of EntityAvatar.java to

if (weapon != null && this.getScene() != null) {
    weapon.setWeaponEntityId(getScene().getWorld().getNextEntityId(EntityIdType.WEAPON));
}

Could you please make this change, so we can fix this bug right away?

GanyusLeftHorn avatar Dec 22 '22 01:12 GanyusLeftHorn

5a9c8c1的标题好像有一个拼写错误XD updata -> update

thanks, i will change it later.

Simplxss avatar Dec 22 '22 03:12 Simplxss

It seems that the content of the email cannot be customized anymore, only the attachment can be modified mail

ERthereal avatar Dec 22 '22 07:12 ERthereal