Grasscutter
Grasscutter copied to clipboard
Update gc to 3.3
Description
Please carefully read the Contributing note and Code of conduct before making any pull requests. And, Do not make a pull request to merge into stable unless it is a hotfix. Use the development branch instead.
Issues fixed by this PR
fix most features
musicgame was delete because of lack of protos.
Type of changes
- [x] Bug fix
- [x] New feature
- [x] Enhancement
- [ ] Documentation
Checklist:
- [x] My code follows the style guidelines of this project
- [x] My pull request is unique and no other pull requests have been opened for these changes
- [x] I have read the Contributing note and Code of conduct
- [x] I am responsible for any copyright issues with my code if it occurs in the future.
尘歌壶、怪物血量、商店 这个提交有修复了吗😲
soon
As far as I know, some of these proto's are useless and some CMDIDs are wrong
As far as I know, some of these proto's are useless and some CMDIDs are wrong
useless protos will be delete later
Which CMDID is wrong? I will fix them
尘歌壶、怪物血量、商店 这个提交有修复了吗😲
all fixed
5a9c8c1的标题好像有一个拼写错误XD updata -> update
So far in my testing, this looks good to me. I noticed one bug - that was probably around before already - with costume switching. You can't switch costumes when the character is not in the active party. This is easily fixed by extending the check in line 61 of EntityAvatar.java
to
if (weapon != null && this.getScene() != null) {
weapon.setWeaponEntityId(getScene().getWorld().getNextEntityId(EntityIdType.WEAPON));
}
Could you please make this change, so we can fix this bug right away?
It seems that the content of the email cannot be customized anymore, only the attachment can be modified