Grasscutter icon indicating copy to clipboard operation
Grasscutter copied to clipboard

Extend give command "skill level" & adding combatskills to shorten /talent all

Open natsurepo opened this issue 2 years ago • 0 comments

Description

Attempting to add talents / skill level as a give command parameter, also shortening /talent all command

  • [x] Adding getCombatSkills for grabbing skill ids specifically for talent command, since getSkillsAndEnergySkill also grabs other unrelated skills
  • [x] Shorten /talent all code
  • [x] Adding skillLevel as parameter so people can also specify talent levels for characters in /give
  • [ ] Resolving the issue for skillLevel parameter messing with constellations not giving extra skillLevel at the end (ex. at C6, talent E and Q doesn't increase by 3)
  • [ ] Cleanup

A bit of note in the end, I would appreciate any suggestions and help for either resolving my current issue and making the implementation tidier.

Type of changes

  • [ ] Bug fix
  • [ ] New feature
  • [x] Enhancement
  • [ ] Documentation

Checklist:

  • [x] My code follows the style guidelines of this project
  • [x] My pull request is unique and no other pull requests have been opened for these changes
  • [x] I have read the Contributing note and Code of conduct
  • [x] I am responsible for any copyright issues with my code if it occurs in the future.

natsurepo avatar Oct 16 '22 13:10 natsurepo