Grasscutter icon indicating copy to clipboard operation
Grasscutter copied to clipboard

feat:cooking food ingredient(aka:compound) implementation

Open eternalcomet opened this issue 2 years ago • 4 comments

Description

Implement food ingredient(compound) feature. Need a thorough test and welcome someone to test it before merging. Known issues: I analyzed the ExcelBinOutput and found that some food ingredient(which is officially called "compound") was not unlocked by default,and all of them are processing fish gained from fishing.I wonder the requirement for unlocking them.

Please carefully read the Contributing note and Code of conduct before making any pull requests. And, Do not make a pull request to merge into stable unless it is a hotfix. Use the development branch instead.

Issues fixed by this PR

Type of changes

  • [ ] Bug fix
  • [x] New feature
  • [x] Enhancement
  • [ ] Documentation

Checklist:

  • [x] My code follows the style guidelines of this project
  • [x] My pull request is unique and no other pull requests have been opened for these changes
  • [x] I have read the Contributing note and Code of conduct
  • [x] I am responsible for any copyright issues with my code if it occurs in the future.

eternalcomet avatar Oct 14 '22 16:10 eternalcomet

By capturing packages from official server,I found the compound related to certain kind of fish will automatically unlocked if the player has this kind of fish in his bag.Is it right?

eternalcomet avatar Oct 14 '22 16:10 eternalcomet

found that some food ingredient(which is officially called "compound") was not unlocked by default,and all of them are processing fish gained from fishing.I wonder the requirement for unlocking them.

Maybe it's just using the compoundid from here for that: https://github.com/tamilpp25/Grasscutter_Resources/blob/9025d5573312ccac4d89417b671964c991e9db44/Resources/ExcelBinOutput/FishExcelConfigData.json#L34

Hartie95 avatar Oct 14 '22 16:10 Hartie95

@Hartie95 Thanks.Because we haven't implement fishing feature,I will unlock all of them in next pr.(I guess official behavior is unlock the compound when player gain the fish from fishing.)

eternalcomet avatar Oct 15 '22 00:10 eternalcomet

demo demo1

eternalcomet avatar Oct 15 '22 03:10 eternalcomet