Grasscutter
Grasscutter copied to clipboard
Grasscutters
Blossom Implement
Description
Please carefully read the Contributing note and Code of conduct before making any pull requests. And, Do not make a pull request to merge into stable unless it is a hotfix. Use the development branch instead.
Issues fixed by this PR
Type of changes
- [ ] Bug fix
- [x] New feature
- [x] Enhancement
- [ ] Documentation
Checklist:
- [x] My code follows the style guidelines of this project
- [x] My pull request is unique and no other pull requests have been opened for these changes
- [x] I have read the Contributing note and Code of conduct
- [x] I am responsible for any copyright issues with my code if it occurs in the future.
Notes from testing:
Map icons don't seem to disappear until teleporting away
Resin doesn't seem to be consumed when claiming rewards, neither original resin nor condensed resin
Condensed resin doesn't give double reward
That's a lot of ley lines
Notes from testing: Map icons don't seem to disappear until teleporting away
Resin doesn't seem to be consumed when claiming rewards, neither original resin nor condensed resin
Condensed resin doesn't give double reward
That's a lot of ley lines
icon will delay to load because of spawn logic, all of blossom will be loaded because I doesn't implement refresh logic which should be implemented with big world collection together
maybe we can use these files to control the logic
"\resources\ExcelBinOutput\BlossomReviseExcelConfigData.json"
"\resources\ExcelBinOutput\BlossomSectionOrderExcelConfigData.json"
"\resources\ExcelBinOutput\BlossomTalkExcelConfigData.json"
"\resources\ExcelBinOutput\BlossomChestExcelConfigData.json"
"\resources\ExcelBinOutput\BlossomGroupsExcelConfigData.json"
"\resources\ExcelBinOutput\BlossomOpenExcelConfigData.json"
"\resources\ExcelBinOutput\BlossomRefreshExcelConfigData.json"(have been used by this pr)
maybe we can use these files to control the logic
"\resources\ExcelBinOutput\BlossomReviseExcelConfigData.json" "\resources\ExcelBinOutput\BlossomSectionOrderExcelConfigData.json" "\resources\ExcelBinOutput\BlossomTalkExcelConfigData.json" "\resources\ExcelBinOutput\BlossomChestExcelConfigData.json" "\resources\ExcelBinOutput\BlossomGroupsExcelConfigData.json" "\resources\ExcelBinOutput\BlossomOpenExcelConfigData.json" "\resources\ExcelBinOutput\BlossomRefreshExcelConfigData.json"(have been used by this pr)
that looks like a huge Engineering,hmmm.. I think this task could move to enhancement plan
so maybe it can be merged?
Meledy has expressed interest in personally reviewing it. In the meantime, loading enemy spawn groups from BlossomGroupsExcelConfigData.json and blossom spawn patterns from BlossomSectionOrderExcelConfig.json to bring things in line with official server behaviour would be a good goal.