Grasscutter icon indicating copy to clipboard operation
Grasscutter copied to clipboard

Published 20 hours ago • verified publisher icon Grasscutters

Toggle constellation

Open juuyokka opened this issue 2 years ago • 2 comments

Description

Allows setConst command to toggle individual constellations, enabling unofficial combinations of constellations. Further discussion is needed on what coreProudSkillLevel should be set to when these unintended constellation states are in effect.

Constellation screen preview Talent screen preview

Issues fixed by this PR

Fixed manage_languages.py to read language files as UTF-8 instead of the default encoding

Type of changes

  • [x] Bug fix
  • [x] New feature
  • [x] Enhancement
  • [ ] Documentation

Checklist:

  • [x] My code follows the style guidelines of this project
  • [x] My pull request is unique and no other pull requests have been opened for these changes
  • [x] I have read the Contributing note and Code of conduct
  • [x] I am responsible for any copyright issues with my code if it occurs in the future.

juuyokka avatar Jul 27 '22 20:07 juuyokka

To ensure that coreProudSkillLevel is well defined, the function setCoreProudSkillLevel has been removed and getCoreProudSkillLevel will calculate the constellation level on the fly instead of retrieving it as a field in the Avatar class.

juuyokka avatar Jul 29 '22 05:07 juuyokka

setConstCommand now has a reset subcommand. I have only tested it in singleplayer.

juuyokka avatar Jul 30 '22 23:07 juuyokka

Recent DMCA compliance push closed active PRs.

This particular PR would need a little bit of changing to match up to recent constellation changes (should be easier to implement the toggle now)

Birdulon avatar Aug 21 '22 12:08 Birdulon