Grasscutter icon indicating copy to clipboard operation
Grasscutter copied to clipboard

[Feature Request] Version Highlights web page ingame

Open RBNXI opened this issue 2 years ago • 9 comments

Is your feature request related to a problem? Please describe. When clicking in the Version Highlights in the game menu, it should redirect you to a html site with the changes of the Genshin version. Since this is unused right now, because it can't get the information from Genshin servers, it would be cool to have a redirection to a local simple webpage that shows the current Grasscutter version changes or the recent commits in the github.

Describe the solution you'd like When clicking this icon

Screenshot_20220722_143205

a website with the information of the current state of Grasscutter is displayed. The icon "Cloud Genshin" redirects you to an error webpage.

Screenshot_20220722_144433

So it should be possible to have whatever html you want displayed in this menus. Then, why not a simple website displaying information about Grasscutter? like current bugs, recent commits, latest stable release...

It's just a gimmick tbh, but it should be easy enough.

RBNXI avatar Jul 22 '22 12:07 RBNXI

20220723125407 这是你想要的 实现的效果 (This is what you want to achieve)https://ci.grasscutter.ga/job/Grasscutter-Dev/

millet6 avatar Jul 23 '22 04:07 millet6

20220723130203 代码正确写法 www.baidu.com改ci.grasscutter.ga/job/Grasscutter-Dev/ (Write the code correctly www.baidu.com to ci.grasscutter.ga/job/grasscutter-dev/)

millet6 avatar Jul 23 '22 05:07 millet6

Yes, somehow. But that redirects all the errors to that site. I want to redirect only the "Version Highlights" section.

RBNXI avatar Jul 23 '22 08:07 RBNXI

https://ci.grasscutter.ga/job/Grasscutter-Dev/changes 你重写网页架构 去侧边栏 (You rewrite the page structure to the sidebar)

millet6 avatar Jul 23 '22 08:07 millet6

I know that this https://ci.grasscutter.ga/job/Grasscutter-Dev/changes shows exactly what I want. But I want to show this only when the "Version Highlights" icon is clicked, not when UnhandledRequestRouter is called. But I don't know what method do "Version Highlights" calls, since it doesn't show an error site. The error site example is what I want this button to show, but if you click "Version Highlights" you will see a blank page, not the error page, so this button calls something that is not UnhandledRequestRouter I think.

RBNXI avatar Jul 23 '22 08:07 RBNXI

I made a fork to apply the changes you said, and indeed, it shows the site (broken, but could be fixed) where the error page was before. But still, in the "Version Highlights" section, I only see this: Screenshot_20220723_105143

RBNXI avatar Jul 23 '22 08:07 RBNXI

Version Highlights 能发图吗?这个按扭 Can you send pictures? This button

millet6 avatar Jul 23 '22 08:07 millet6

Version Highlights 能发图吗?这个按扭 Can you send pictures? This button

Oh, there is a picture in my first comment, in the section "Describe the solution you'd like", after "When clicking this icon:"

RBNXI avatar Jul 23 '22 09:07 RBNXI

Oh, I see.

millet6 avatar Jul 23 '22 09:07 millet6