Cultivation icon indicating copy to clipboard operation
Cultivation copied to clipboard

Published 20 hours ago • verified publisher icon Grasscutters

Disable CSP errors while loading js files from themes

Open TotallyNotOndre opened this issue 2 years ago • 3 comments

Disables CSP errors while loading themes js files Before: image

After: image

TotallyNotOndre avatar Aug 01 '22 21:08 TotallyNotOndre

As I mentioned in Discord, allowing JavaScript in themes is not safe, at least in the current implementation. We should probably fix that before landing this fix.

Seeker14491 avatar Aug 02 '22 11:08 Seeker14491

While yes, JS in themes isn't the safest idea, if you have some common sense and read the theme's source code before installing, its a nice thing for theme creators to use.

KingRainbow44 avatar Aug 05 '22 15:08 KingRainbow44

Most Cultivation users aren't coders who can read JS, so it's not reasonable to ask them to read themes' source code. I agree JS is useful for themes though.

Seeker14491 avatar Aug 06 '22 00:08 Seeker14491