teem icon indicating copy to clipboard operation
teem copied to clipboard

Login model issue

Open divyanshu-rawat opened this issue 7 years ago • 5 comments

There is no left & right padding wrt browser window. Screen Size - md md

Screen Size - sm sm

Screen SIze - xs xs

Can I work on this issue ?

divyanshu-rawat avatar Mar 03 '17 13:03 divyanshu-rawat

@atfornes please look at the issue .

divyanshu-rawat avatar Mar 03 '17 15:03 divyanshu-rawat

@divyanshu-rawat, feel free to work in this issue if you like.

I will soon prioritize and mark important and easy issues in Teem so it is easier to find on what to work.

atfornes avatar Mar 04 '17 17:03 atfornes

@atfornes I tried solving it

Snapshot after fixing in chrome dev tools when screen size is xs

issue_xs

Snapshot after fixing in chrome dev tools when screen size is sm

issue_sm

But the issue that I am facing right now is that I am not been able to figure out where the .model-dialog class is located in the source code. As per snapshot, I changed the padding of .model-dialog class from 0 to 5% that's why the model is not touching left and right browser window. But In order to make a permanent change, I need to find where .model-class is located in source code.

Why chrome dev tools are pointing to colors.sass? colors.sass does not contain any .model-dialog class !

divyanshu-rawat avatar Mar 05 '17 07:03 divyanshu-rawat

@divyanshu-rawat Here is the modal.scss at src/sass/modal.sass file which has the details of the modal dialog class. I added 5% to padding and it did the job!

screen shot 2017-03-05 at 6 31 34 pm

krshubham avatar Mar 05 '17 13:03 krshubham

@atfornes , what about this issue? Should I make the padding changes, or its not needed?

krshubham avatar Sep 07 '17 14:09 krshubham