Graphite icon indicating copy to clipboard operation
Graphite copied to clipboard

Improve usage of history states throughout the application

Open Keavon opened this issue 2 years ago • 4 comments

History states (undo/redo) are implemented, but many tools and actions and messages don't save history states when they need to. The resulting experience is quite unpleasant since it's easy to lose work or end up undoing/redoing way more than expected. This task involves experimenting with lots of everything, basically doing a QA test on everything, and fixing all the problems with history wherever one shows up. Related: #559

Keavon avatar Apr 21 '22 07:04 Keavon

I'll work on this one.

RahulHi avatar May 26 '22 18:05 RahulHi

How is this going @RahulHi? Need any help?

Keavon avatar Jun 19 '22 02:06 Keavon

Hi @RahulHi, just another friendly check-in. Let me know if there's anything I can do to help push this along. Cheers!

Keavon avatar Aug 06 '22 00:08 Keavon

@Keavon Will do! There isn't anything right now, but I will be sure to let you know of any questions I have!

RahulHi avatar Aug 10 '22 01:08 RahulHi

Should every action produce a history to enable undo/redo? Even actions like using the Navigate Tool?

noblehelm avatar Oct 12 '22 17:10 noblehelm

@noblehelm Technically, using the Navigate Tool modifies the document, but we ideally would like to filter out some obvious things like that from counting for history. But it's probably better if we can make that opt-out rather than opt-in since currently it's too easy to implement features and forget about making them support history. The history system is quite crippled right now and really any improvements would be of vital importance.

Keavon avatar Oct 12 '22 17:10 Keavon

Closed by #932

Keavon avatar Jan 15 '23 01:01 Keavon