Graphite icon indicating copy to clipboard operation
Graphite copied to clipboard
verified publisher icon GraphiteEditor

feat: Add spacing method options to Repeat and Circular Repeat nodes

Open a-khushal opened this issue 1 month ago • 7 comments

Closes #2551 image

@Keavon

a-khushal avatar Nov 16 '25 20:11 a-khushal

!build

Keavon avatar Nov 29 '25 08:11 Keavon

📦 Build Complete for 16f49221296c334d0b9080914f9f111f57f9dbc0
https://94ab8d03.graphite.pages.dev

github-actions[bot] avatar Nov 29 '25 08:11 github-actions[bot]

"Width" is not supposed to be a parameter.

Keavon avatar Nov 29 '25 08:11 Keavon

@Keavon can you please review this now?

a-khushal avatar Nov 30 '25 13:11 a-khushal

!build

Keavon avatar Nov 30 '25 22:11 Keavon

📦 Build Complete for 2ab55ec53aa6b7086426aa764e9c44d5350a07a1
https://33d7c766.graphite.pages.dev

github-actions[bot] avatar Nov 30 '25 22:11 github-actions[bot]

Hi @Keavon, any updates on the review when you get a moment?

a-khushal avatar Dec 06 '25 12:12 a-khushal

Repeat Node

Span, Pitch, and Gap work as intended.

Envelope does not. The initial shape should remain in the same position, but Envelope mode currently shifts it. See below for details:

The orange dot at (0, 0) marks the canvas center, and in both examples the rectangle starts centered on the canvas. Current: Current

Expected: Expected

File (rename to .graphite): pr3389-Repeat.txt

Circular Repeat Node

This PR breaks the Circular Repeat node.

The Repeat node uses Direction to define spacing, but Circular Repeat previously distributed instances evenly around the circle by default. This PR doesn’t account for that original behavior.

Video:

https://github.com/user-attachments/assets/19aad6d4-99b9-487c-8cba-138cf87d5030

File (rename to .graphite): pr3389-Circular_Repeat.txt

CC @Keavon

Ezbaze avatar Dec 12 '25 04:12 Ezbaze