Graphite icon indicating copy to clipboard operation
Graphite copied to clipboard

add arrow shape feature in editor

Open krVatsal opened this issue 1 month ago • 12 comments

Add a new arrow shape tool

Closes #3317

krVatsal avatar Nov 04 '25 11:11 krVatsal

!build

timon-schelling avatar Nov 04 '25 12:11 timon-schelling

📦 Build Complete for 989f4bac7083c046ad8e290ae9f357f6c8e89a29
https://8e0fa0ab.graphite.pages.dev

github-actions[bot] avatar Nov 04 '25 12:11 github-actions[bot]

I know still a draft, but a arrow node might be something to consider. Like it is done for all other shapes.

Thanks for the contribution :)

timon-schelling avatar Nov 04 '25 17:11 timon-schelling

I haven't read the (draft) PR's code, but what is the tooling doing if it's not controlling an arrow generator node?

Keavon avatar Nov 04 '25 17:11 Keavon

the (draft) PR's code, but what is the tooling doing if it's

creating a path node

timon-schelling avatar Nov 04 '25 17:11 timon-schelling

That wouldn't allow the user to parametrically edit the arrow shape. The goal is to add handles to drag its width, length, arrow head's front and back angles, and arrow head width and height. That all has to be written to the parameters of an Arrow node. @krVatsal please be aware of these details for the requirements of this feature. Thank you.

Keavon avatar Nov 04 '25 18:11 Keavon

Sure @Keavon

krVatsal avatar Nov 04 '25 20:11 krVatsal

📦 Build Complete for f3b1179524ce7fe2d498cf930e8625dff939ddd8
https://828f1024.graphite.pages.dev

github-actions[bot] avatar Nov 10 '25 14:11 github-actions[bot]

The arrow position is correct now, I would prefer if it was flipped though, starting at the base and dragging to the tip (just my opinion).

And reminder about the requirement of a new arrow node. Just a path node with arrow data generated by the tool is not enough. Take another look at other shape nodes (like Regular Polygon in the Image).

image

That wouldn't allow the user to parametrically edit the arrow shape. The goal is to add handles to drag its width, length, arrow head's front and back angles, and arrow head width and height. That all has to be written to the parameters of an Arrow node. @krVatsal please be aware of these details for the requirements of this feature. Thank you.

timon-schelling avatar Nov 10 '25 15:11 timon-schelling

The arrow position is correct now, I would prefer if it was flipped though, starting at the base and dragging to the tip (just my opinion).

And reminder about the requirement of a new arrow node. Just a path node with arrow data generated by the tool is not enough. Take another look at other shape nodes (like Regular Polygon in the Image).

image > That wouldn't allow the user to parametrically edit the arrow shape. The goal is to add handles to drag its width, length, arrow head's front and back angles, and arrow head width and height. That all has to be written to the parameters of an Arrow node. @krVatsal please be aware of these details for the requirements of this feature. Thank you.

Got it, I'll fix it soon!

krVatsal avatar Nov 10 '25 16:11 krVatsal

!build

timon-schelling avatar Nov 11 '25 11:11 timon-schelling

Hi, are there any further changes required?

krVatsal avatar Nov 16 '25 13:11 krVatsal