add arrow shape feature in editor
Add a new arrow shape tool
Closes #3317
!build
| 📦 Build Complete for 989f4bac7083c046ad8e290ae9f357f6c8e89a29 |
|---|
| https://8e0fa0ab.graphite.pages.dev |
I know still a draft, but a arrow node might be something to consider. Like it is done for all other shapes.
Thanks for the contribution :)
I haven't read the (draft) PR's code, but what is the tooling doing if it's not controlling an arrow generator node?
the (draft) PR's code, but what is the tooling doing if it's
creating a path node
That wouldn't allow the user to parametrically edit the arrow shape. The goal is to add handles to drag its width, length, arrow head's front and back angles, and arrow head width and height. That all has to be written to the parameters of an Arrow node. @krVatsal please be aware of these details for the requirements of this feature. Thank you.
Sure @Keavon
| 📦 Build Complete for f3b1179524ce7fe2d498cf930e8625dff939ddd8 |
|---|
| https://828f1024.graphite.pages.dev |
The arrow position is correct now, I would prefer if it was flipped though, starting at the base and dragging to the tip (just my opinion).
And reminder about the requirement of a new arrow node. Just a path node with arrow data generated by the tool is not enough. Take another look at other shape nodes (like Regular Polygon in the Image).
That wouldn't allow the user to parametrically edit the arrow shape. The goal is to add handles to drag its width, length, arrow head's front and back angles, and arrow head width and height. That all has to be written to the parameters of an Arrow node. @krVatsal please be aware of these details for the requirements of this feature. Thank you.
The arrow position is correct now, I would prefer if it was flipped though, starting at the base and dragging to the tip (just my opinion).
And reminder about the requirement of a new arrow node. Just a path node with arrow data generated by the tool is not enough. Take another look at other shape nodes (like
Regular Polygonin the Image).> That wouldn't allow the user to parametrically edit the arrow shape. The goal is to add handles to drag its width, length, arrow head's front and back angles, and arrow head width and height. That all has to be written to the parameters of an Arrow node. @krVatsal please be aware of these details for the requirements of this feature. Thank you.
Got it, I'll fix it soon!
!build
Hi, are there any further changes required?
> That wouldn't allow the user to parametrically edit the arrow shape. The goal is to add handles to drag its width, length, arrow head's front and back angles, and arrow head width and height. That all has to be written to the parameters of an Arrow node. @krVatsal please be aware of these details for the requirements of this feature. Thank you.