Graphite icon indicating copy to clipboard operation
Graphite copied to clipboard

Add major/minor grid lines to grids popover

Open bluelinden opened this issue 1 month ago • 12 comments

This PR adds a major/minor grid line system that allows for better usability of precise grids when zoomed farther out.

The implementation is inspired by Inkscape's.

bluelinden avatar Nov 03 '25 05:11 bluelinden

!build

Keavon avatar Nov 03 '25 06:11 Keavon

📦 Build Complete for 489ca9549c806d5fe3033ddec6accef9c860abf1
https://d8d0d724.graphite.pages.dev

github-actions[bot] avatar Nov 03 '25 06:11 github-actions[bot]

!build

Keavon avatar Nov 03 '25 06:11 Keavon

📦 Build Complete for 7732aca3997f681db9c967151a9823195bab161a
https://6f67539d.graphite.pages.dev

github-actions[bot] avatar Nov 03 '25 06:11 github-actions[bot]

!build

timon-schelling avatar Nov 17 '25 18:11 timon-schelling

📦 Build Complete for 5c6ab754508410edd2e4730eb43ea38b3dfa69ff
https://a325dc94.graphite.pages.dev

github-actions[bot] avatar Nov 17 '25 18:11 github-actions[bot]

!build

timon-schelling avatar Nov 17 '25 18:11 timon-schelling

📦 Build Complete for e5e3e5a5b1ebc4f71b11811d20c9eb5b77eb1fca
https://c089fa70.graphite.pages.dev

github-actions[bot] avatar Nov 17 '25 18:11 github-actions[bot]

!build

Keavon avatar Nov 17 '25 21:11 Keavon

📦 Build Complete for c560ba6ccb8130b990951ab4bb896aec8dbddeb2
https://b2a337b8.graphite.pages.dev

github-actions[bot] avatar Nov 17 '25 21:11 github-actions[bot]

!build

timon-schelling avatar Nov 20 '25 02:11 timon-schelling

📦 Build Complete for eaa4ffe8fc56489d5d5ae23754d4c5de93218d6a
https://ead5f7ea.graphite.pages.dev

github-actions[bot] avatar Nov 20 '25 02:11 github-actions[bot]

Sorry for taking so long to take a look, Code looks good in general. We need to rebase though. (And the dot may be moved to the branding repo, not because it's copyrightable, but to keep all icons in one place. @Keavon)

I may have noticed one logic bug, lines and dots don't match the same pattern here.

image image

And If I remember correctly I somehow got into a state where the second color selection element would not disappear with 1 1 1, but I'm not able to reproduce that, not a blocker in my opinion.

timon-schelling avatar Dec 17 '25 23:12 timon-schelling