Graphite icon indicating copy to clipboard operation
Graphite copied to clipboard

Add lasso selection to node graph

Open wade-cheng opened this issue 1 month ago • 8 comments

Closes #2532.

wade-cheng avatar Nov 03 '25 02:11 wade-cheng

I should say while this is on my mind right now, performance should probably be looked at for this PR. We convert the entire vec of polygon points from one unit to another once every frame.

wade-cheng avatar Nov 08 '25 22:11 wade-cheng

Made some initial tweaks, discussion above. Feel free to mark whatever resolved if you agree with changes.

I suppose the last holdup is the "point in polygon" note that I'd be stuck on.

wade-cheng avatar Nov 24 '25 23:11 wade-cheng

Oh, hm. Looks like the hints only show esc/rmb to cancel, but not the extend/subtract hints that show up when using the artboard drag select tool. As you are indeed able to extend/subtract, should I add them through a commit here or leave it for a later mini PR?

Searched is:issue state:open node drag hint on the tracker but didn't find any matches.

wade-cheng avatar Nov 25 '25 04:11 wade-cheng

Yes, feel free to include them in the PR here.

Keavon avatar Nov 25 '25 06:11 Keavon

Included :+1:

wade-cheng avatar Nov 26 '25 03:11 wade-cheng

!build

Keavon avatar Nov 28 '25 00:11 Keavon

📦 Build Complete for 213fe29ee818d011afed80f7f39b34550cf215ba
https://16f20691.graphite.pages.dev

github-actions[bot] avatar Nov 28 '25 00:11 github-actions[bot]

On Mac, there's a discrepancy between the canvas which uses Ctrl and the node graph which uses Cmd (Accel). You should probably make both use both Ctrl and Accel. Since we'd like the node graph and the canvas to work with both Cmd and Ctrl on Mac, and Ctrl on Windows/Linux.

Keavon avatar Nov 28 '25 03:11 Keavon