Graphite icon indicating copy to clipboard operation
Graphite copied to clipboard

Add arrow key navigation for node catalog

Open Rohan2460 opened this issue 2 months ago • 13 comments

Implements navigation in node catalog using up and down arrow keys and node selection using enter key. Selected node is emphasized.

Closes #3235

Rohan2460 avatar Sep 28 '25 20:09 Rohan2460

!build

timon-schelling avatar Sep 29 '25 06:09 timon-schelling

📦 Build Complete for 39bbf67e9f822a5b0fe8c37569213edbb2c6af06
https://c732d0b5.graphite.pages.dev

github-actions[bot] avatar Sep 29 '25 06:09 github-actions[bot]

@timon-schelling I added 'focused' prop to TextButton, is that ok ? graphite_node

Rohan2460 avatar Oct 03 '25 13:10 Rohan2460

!build

timon-schelling avatar Oct 03 '25 13:10 timon-schelling

I will take a look once the build is done.

timon-schelling avatar Oct 03 '25 13:10 timon-schelling

📦 Build Complete for 838c92785557da3fbd79c81ed2337bdb74a8ecdc
https://a35828fd.graphite.pages.dev

github-actions[bot] avatar Oct 03 '25 13:10 github-actions[bot]

!build

timon-schelling avatar Oct 03 '25 16:10 timon-schelling

📦 Build Complete for 7665ca84e3c1478dfd4794f2b79f5a2f023f5a4c
https://690a0632.graphite.pages.dev

github-actions[bot] avatar Oct 03 '25 16:10 github-actions[bot]

this can be merged right? @Keavon not sure if your comment meant approval...

timon-schelling avatar Oct 15 '25 01:10 timon-schelling

Still need to QA and do another review round.

Keavon avatar Oct 15 '25 06:10 Keavon

I reverted the changes to the TextButton component and overwrote the emphasized css class.

Rohan2460 avatar Oct 17 '25 15:10 Rohan2460

!build

timon-schelling avatar Oct 17 '25 16:10 timon-schelling

📦 Build Complete for 1909dbb6c518565a0faa3a95268442e96bf96cdb
https://eabd5fef.graphite.pages.dev

github-actions[bot] avatar Oct 17 '25 16:10 github-actions[bot]

I think this PR may be outdated now. Commit https://github.com/GraphiteEditor/Graphite/commit/600fb5c28f9bdedbdcaf06b5ab1804f674c6e9d7 already adds tab navigation within the node graph editor context menu, which seems to cover the same issue.

Context menu behaviour as of https://github.com/GraphiteEditor/Graphite/commit/d6c06da878beca527f1c90b4ace000fca98752b3 (latest commit as of writing this comment)

https://github.com/user-attachments/assets/4f31891b-4c40-4e8e-aa55-4da135688a4c

CC @Keavon

Ezbaze avatar Dec 11 '25 23:12 Ezbaze

In my opinion, the tab selection is not sufficient, highlighting could be better and arrow key navigation is more usable. We should also think about adding a keyboard shortcut that allow users to open the dialog without touching the mouse. Node selection (witch is inherently keyboard focused) would be faster.

timon-schelling avatar Dec 12 '25 01:12 timon-schelling

Since this is now possible from the keyboard as Ezbaze showed in the video he posted, that's sufficient. The entire menu will be replaced by a proper context menu once that system comes online pretty soon. So this should indeed make this PR redundant. Thanks @Rohan2460 for your attempt on it!

Keavon avatar Dec 12 '25 02:12 Keavon