Graphite icon indicating copy to clipboard operation
Graphite copied to clipboard

Fix: check if path tool is interacting with raster layer to prevent crashing.

Open KartikSharma0 opened this issue 3 months ago • 9 comments

Resolves #2687 Added a check that returns PathToolFsmState::Ready if the path tool is used on a raster layer.

KartikSharma0 avatar Sep 16 '25 04:09 KartikSharma0

!build

Keavon avatar Sep 16 '25 04:09 Keavon

📦 Build Complete for e8a0e362b2cc3927c51fad786ee99a48590ab4d4
https://96d679d7.graphite.pages.dev

github-actions[bot] avatar Sep 16 '25 04:09 github-actions[bot]

Video of the fix:

https://github.com/user-attachments/assets/580c80df-8336-41c8-b68b-f8bfc82ac453

KartikSharma0 avatar Sep 16 '25 05:09 KartikSharma0

Please let me know if the video above captures the expected behavior.

KartikSharma0 avatar Sep 16 '25 05:09 KartikSharma0

This does not remove anchors from the corners of the image. All it does is break the Path tool's ability to select stuff, either a box selection or even clicking on other valid points if multiple layers (including actual vector layers) are selected. Please give it another shot so it addresses the requested change (first sentence of this reply).

Keavon avatar Sep 16 '25 05:09 Keavon

So there shouldn't be any anchors displayed on the image at all when the path tool is selected? The path tool still works on the spline as shown, it's just ignoring the raster image.

KartikSharma0 avatar Sep 16 '25 05:09 KartikSharma0

I added a check before showing the anchors/handles. Please let me know if this PR is in-line with what you expected now.

KartikSharma0 avatar Sep 17 '25 04:09 KartikSharma0

Okay, I simplified the code changes. I think this PR should fulfill the requirements now.

KartikSharma0 avatar Sep 18 '25 06:09 KartikSharma0

📦 Build Complete for fca9dabe8e8dfc0bbbd2a6c1d434940634cd3073
https://f3db9350.graphite.pages.dev

github-actions[bot] avatar Sep 20 '25 20:09 github-actions[bot]

@Keavon Should we merge this?

TrueDoctor avatar Dec 20 '25 20:12 TrueDoctor