Graphite icon indicating copy to clipboard operation
Graphite copied to clipboard

Add distance validation in merge function and clamp grid coords

Open Freeslugga opened this issue 3 months ago • 4 comments

Closes #3155 - Crash when merging brush layer into boolean layer in debug

both changes to rs files in node-graph, merge handling was improper, causing a panic with certain data types. Also clamped the grid points to avoid invalid data being passed.

Freeslugga avatar Sep 13 '25 05:09 Freeslugga

Currently the crash is fixed, but when you add a brush layer to the boolean group it rescales and moves the brush layer to the point where it is invisible. You are able to reset the scale and location via the properties menu and the brush re-appears.

Freeslugga avatar Sep 13 '25 06:09 Freeslugga

Not sure where the transforms are taking place, I can open as a separate issue if this is merged.

Freeslugga avatar Sep 13 '25 06:09 Freeslugga

@Keavon This is my first contribution to an open-source project, please let me know if you have any direct feedback to better assist my journey with contributing!

Freeslugga avatar Sep 13 '25 23:09 Freeslugga

Thanks, I will be busy for the next day or two as I get the next release out, then I'll try to take a look. Feel free to take on more issues in the meantime.

Keavon avatar Sep 14 '25 02:09 Keavon