Graphite icon indicating copy to clipboard operation
Graphite copied to clipboard

Bulk rename `gcore` -> `gstd` in `editor`

Open Firestar99 opened this issue 6 months ago • 3 comments

Requires https://github.com/GraphiteEditor/Graphite/pull/2733

bulk renames, for code changes see https://github.com/GraphiteEditor/Graphite/pull/2729

Firestar99 avatar Jun 17 '25 17:06 Firestar99

I'm adding reexports, and the node macro generated mod image is conflicting with reexporting gcore::raster::image in gstd. May have to rename it, not sure to what.

Can you rexport gcore::raster::* from inside gstd::raster?

TrueDoctor avatar Jun 18 '25 10:06 TrueDoctor

And you could rename the gcore::raster module to something else to avoid coflicts. Then we don't have to rename anything in editor

TrueDoctor avatar Jun 18 '25 10:06 TrueDoctor

And you could rename the gcore::raster module to something else to avoid coflicts. Then we don't have to rename anything in editor

This PR makes editor to only depend on gstd and removes it's dependency on gcore. Instead, all of gcore is reexported in gstd. This allows me to rip apart gcore without editor being affected, as long as I continue to reexport all nodes in gstd. Saving us a lot of conflicts down the line.

Firestar99 avatar Jun 18 '25 10:06 Firestar99