Graphite icon indicating copy to clipboard operation
Graphite copied to clipboard
verified publisher icon GraphiteEditor

Move the math expression parser from Pest to Chumsky and add more features

Open urisinger opened this issue 6 months ago • 3 comments

Part of #2026

Switches to the chumsky parser for performance, remove Unit support until #586 is resolved.

Improves parser performance by about 40%, while also reducing compile times and improving readability.

urisinger avatar Jun 03 '25 15:06 urisinger

I have rebased this branch to remove merge commits, so you'll need to git reset --hard to its new ref here on origin.

Keavon avatar Jun 20 '25 08:06 Keavon

How far is this?

I might be interested in implementing some math expressions from #2026 I figured this PR would be a blocking factor before I could do that.

RegenJacob avatar Oct 05 '25 21:10 RegenJacob

How far is this?

I might be interested in implementing some math expressions from #2026 I figured this PR would be a blocking factor before I could do that.

Its ready for review, its just not being merged becuase without variadics of some form this node is pretty useless, creating the custom error message for the node is also a difficult task.

urisinger avatar Oct 06 '25 09:10 urisinger