Graphite icon indicating copy to clipboard operation
Graphite copied to clipboard

Add fill tool support on strokes

Open seam0s-dev opened this issue 7 months ago • 8 comments

This PR adds support for fill on strokes while using the fill tool as requested in #2615.

seam0s-dev avatar May 22 '25 18:05 seam0s-dev

Test cases: stroke fill pattern.graphite.txt

seam0s-dev avatar May 26 '25 14:05 seam0s-dev

See the video for the issues this encounters:

https://github.com/user-attachments/assets/bdc41b02-d167-4643-9a88-0d9bbab76a32

Here's the file with this shape (remove the .txt from the file after downloading it):

issues.graphite.txt

Keavon avatar Jun 09 '25 00:06 Keavon

@Keavon The issue does not seem to affect shapes constructed using pen tool:

https://github.com/user-attachments/assets/041b9cff-0402-4ce0-82a2-c0d183e43c6d

seam0s-dev avatar Jun 09 '25 08:06 seam0s-dev

You likely need to take into account the local transform, the nested transform spaces to reach from local space to document space, and the stroke transform (which is affected by scaling or skewing a grouped layer, for example).

Keavon avatar Jun 09 '25 08:06 Keavon

!build

Keavon avatar Jun 10 '25 16:06 Keavon

📦 Build Complete for de70263ddccb01bf1fcbba5e11cc5fd26752a017
https://cfa9993d.graphite.pages.dev

github-actions[bot] avatar Jun 10 '25 16:06 github-actions[bot]

capture file.graphite.txt

Keavon avatar Jun 10 '25 16:06 Keavon

I have force pushed this branch to move it to a new base. Ensure you have the branch checked out. Then please run git stash on any local changes (and ask me before following these steps if you have any un-pushed commits on your local machine). Then fetch this branch and git reset --hard origin/2615-fill-tool-on-strokes. And finally git stash pop your stashed local changes, if you stashed them.

Keavon avatar Jun 20 '25 08:06 Keavon