Graphite icon indicating copy to clipboard operation
Graphite copied to clipboard

Store network metadata information in the node network (prep for Graphene-rendered node graph UI)

Open adamgerhant opened this issue 1 year ago • 2 comments

Stores all network metadata as value inputs to cloned nodes. This will allow the new node graph rendering process to have access to the metadata.

TODO: Toggle to layer is broken

adamgerhant avatar Sep 04 '24 07:09 adamgerhant

Found Clippy warnings

Clippy Warnings/Errors

warning: this expression creates a reference which is immediately dereferenced by the compiler
    --> editor/src/messages/portfolio/document/utility_types/network_interface.rs:1037:74
     |
1037 |         let Some(tagged_value) = self.metadata_value(MetadataType::Previewing, &network_path) else {
     |                                                                                ^^^^^^^^^^^^^ help: change this to: `network_path`
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
     = note: `-W clippy::needless-borrow` implied by `-W clippy::all`
     = help: to override `-W clippy::all` add `#[allow(clippy::needless_borrow)]`

warning: this expression creates a reference which is immediately dereferenced by the compiler
    --> editor/src/messages/portfolio/document/utility_types/network_interface.rs:1049:111
     |
1049 |         let Some(tagged_value) = self.metadata_value(MetadataType::NavigationMetadata(NavigationMetadataType::PTZ), &network_path) else {
     |                                                                                                                     ^^^^^^^^^^^^^ help: change this to: `network_path`
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> editor/src/messages/portfolio/document/utility_types/nodes.rs:154:3
    |
154 |         &self
    |         ^^^^^ help: change this to: `self`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: `graphite-editor` (lib) generated 3 warnings (run `cargo clippy --fix --lib -p graphite-editor` to apply 3 suggestions)
warning: `graphite-editor` (lib test) generated 3 warnings (3 duplicates)
warning: `graphite-editor` (lib) generated 3 warnings (3 duplicates)
    Finished `dev` profile [optimized + debuginfo] target(s) in 4m 55s

github-actions[bot] avatar Sep 04 '24 07:09 github-actions[bot]

@adamgerhant do we close this? I don't recall what the status of this PR is, besides it's old and has a lot of merge conflicts. Did #2105 supersede this, or does this have a different focus from that? Is there anything this had set out to accomplish that is still needed to be accomplished today?

Keavon avatar Jan 25 '25 09:01 Keavon

I'm going to assume the answer to my previous comment's question is yes, but let me know otherwise if this should be reopened.

Keavon avatar Nov 14 '25 21:11 Keavon