Graphite icon indicating copy to clipboard operation
Graphite copied to clipboard

Restore functionality of Imaginate

Open Keavon opened this issue 1 year ago • 3 comments

Closes #1511

Keavon avatar May 26 '24 08:05 Keavon

I think this can probably be closed, most of the relevant parts of the code have been merged in other prs, the only thing worth extracting would be the cloudflare api interaction, Thoughts @Keavon ?

TrueDoctor avatar Aug 07 '24 13:08 TrueDoctor

I plan to extract the API parts once the deadlock is fixed, then I'll either close or reuse this PR for the API stuff.

Keavon avatar Aug 07 '24 22:08 Keavon

Found Clippy warnings

Clippy Warnings/Errors

error[E0308]: mismatched types
   --> node-graph/gcore/src/raster/image.rs:167:86
    |
167 |             .write_image(bytemuck::cast_slice(self.data.as_slice()), self.width, self.height, ::image::ColorType::Rgba8)
    |              ----------- arguments to this method are incorrect                               ^^^^^^^^^^^^^^^^^^^^^^^^^ expected `ExtendedColorType`, found `ColorType`
    |
note: method defined here
   --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/image-0.25.2/src/image.rs:772:8
    |
772 |     fn write_image(
    |        ^^^^^^^^^^^
help: call `Into::into` on this expression to convert `image::ColorType` into `image::ExtendedColorType`
    |
167 |             .write_image(bytemuck::cast_slice(self.data.as_slice()), self.width, self.height, ::image::ColorType::Rgba8.into())
    |                                                                                                                        +++++++

error[E0308]: mismatched types
   --> node-graph/gcore/src/raster/image.rs:235:45
    |
235 |         encoder.write_image(&data, width, height, ::image::ColorType::Rgba8).expect("failed to encode image as png");
    |                 -----------                       ^^^^^^^^^^^^^^^^^^^^^^^^^ expected `ExtendedColorType`, found `ColorType`
    |                 |
    |                 arguments to this method are incorrect
    |
note: method defined here
   --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/image-0.25.2/src/image.rs:772:8
    |
772 |     fn write_image(
    |        ^^^^^^^^^^^
help: call `Into::into` on this expression to convert `image::ColorType` into `image::ExtendedColorType`
    |
235 |         encoder.write_image(&data, width, height, ::image::ColorType::Rgba8.into()).expect("failed to encode image as png");
    |                                                                            +++++++

For more information about this error, try `rustc --explain E0308`.
error: could not compile `graphene-core` (lib) due to 2 previous errors
warning: build failed, waiting for other jobs to finish...

github-actions[bot] avatar Aug 17 '24 13:08 github-actions[bot]