os-issue-tracker
os-issue-tracker copied to clipboard
GrapheneOS
Add support for limited user facing CarrierConfig overrides
Would allow some people to get working VoLTE, in regions not supported by Google.
It would be great if there would also be support of importing vendor's mbn files, as the needed mbn files for certain regions are not included in pixel, here is an example of mbn files that works for pixel 5 Pixel-Redbull-Carrier-Patch. Another good solution could be publishing an automation building tool (#1137 ), which could make the os easier to use in regions not supported
Using 3rd party mbn files isn't supposed to be possible. We aren't going to ship them and it's not relevant to this.
I see, I do understand there might be some security concern of using third party mbn files, it is just that I can't see vendors in my country would ever support pixel, and in this case, building it from scratch seems to be the only choice. May I also ask how bad it could be from using third party mbn files?
You quite literally aren't supposed to be able to do it. It's a bug if it's even possible. It's not something that can be reasonably considered to be production suitable.
Let me ask differently :). How high it is on your priority list? This is very important question for people outside of Pixel supported countries, taking into account fact of sunsetting 2g and 3g networks in very near future worldwide.
It's not a high priority and bumping and pinging us isn't going to change it. If someone wants it so badly and immediately they can write a patch that meets our guidelines, verify it works, and submit a pull request.
If this is not relevant place for such discussion please redirect me then. I'm not demanding anything from you, just politely asking for information that I couldn't find elsewhere. I guess you would agree its a good thing to know when your about to invest 1000 dollars into a device that may turn into paperweight in a year or two. Do you have a clear idea how this feature should work? If it doesn't require extensive knowledge of Android system and telecommunications to implement then I could try to help.
It would be very beneficial for everyone outside Google's preferred region. Can someone write down here what would it take to make it a reality? What are the variables that need to be toggled by the settings app? Or how much money one would like to get by creating this feature?
This concept is explored by https://github.com/kyujin-cho/pixel-volte-patch (Not vouching for it or anything to be clear, I just skim read the code).
Hello, I have just tested kyujin-cho pixel-volte-patch on latest stable GrapheneOS and it is working, VoLTE and VoWifi on O2 Czech Republic - unsupported country by google, its masive usability boost.
Yeah not surprised that it works, but we want this in the OS, we don't want people adding needless attack surface just to enable VoLTE.
that is reason why I let you know, if something like this works , smarter people than me can maybe figure out way to do this in OS. All I can do is test it.
This concept is explored by https://github.com/kyujin-cho/pixel-volte-patch (Not vouching for it or anything to be clear, I just skim read the code).
Aparantly the way this works is very simple in the actual patch part. they just do a non invasive override by switching (CarrierConfigManager.KEY_CARRIER_VOLTE_AVAILABLE_BOOL) to be TRUE and for wifi calling (CarrierConfigManager.KEY_CARRIER_WFC_IMS_AVAILABLE_BOOL) to TRUE as seen here and some info from google here
So if Settings > Network & internet > SIMs > YOUR CARRIER > VoLTE is not shown our carriers are probally pushing KEY_HIDE_ENHANCED_4G_LTE_BOOL as TRUE as seen here
Should really be a simple fix to override, might not work on every carrier but as its very non invasive and works on most of them. Maybe some switches that default to off could be considered to be made under the SIM menu to force the override? So people don't have to install a whole app to do a simple override
In the meantime, is using the pixel-volte-patch and shizuku a security threat? For example if I use the app and clear phone memory to defauls? These apps don't require root, but can they somehow plant themselves into the phone?
I am talking here mostly about using their own APK binary, which was build by the author (by the way Izzy puts Shizuku on his own repo, but I am not sure if he makes his own builds or uses the builds from the author - more details here https://github.com/RikkaApps/Shizuku/issues/69 )
Thanks for the comment! Now I understand more: that Shizuku is actually performing USB/wireless debugging on the OS, so now I see that it might do something really wrong.
ADB provides a massive amount of access even on a production (user) build, and on a userdebug build it even provides root access. ADB without the network feature relies on requiring physical access in addition to key-based authentication which expires. Network ADB support is actually quite problematic and is a malware persistence method reducing the security provided by verified boot substantially. We plan to do something about it, but we aren't quite sure exactly what we want to do yet.
Is this still being worked on? Would be a major improvement for users in countries where 3G is being abandoned.
Issue has been locked due to misuse of the issue tracker. It may delay the feature being implemented due to contributors being unable to discuss it here.